Add a Windows build workflow - #1619
Merged
Merged
Conversation
Runs the full test suite on windows-latest against a nats-server built from the tip of main, on every push to main. Windows has never had CI coverage here, and several of the server bugs found through the Java tests over the years were specific to the Windows environment. The shared synadia-io/workflows install action is bash and unix-only, so this workflow installs the server itself rather than making that action cross platform. It builds nats-server.exe and hands the absolute path to the test harness through the nats_server_path environment variable, which NatsRunnerUtils.getResolvedServerPath() reads - that keeps PATH and PATHEXT out of the picture on a platform where an extensionless binary is not resolvable as a command. Java 8 only, matching the other builds. No jacoco, coveralls, javadoc or publishing: those are covered on Linux and would only add runtime and failure surface. Test reports upload as an artifact on failure, since triaging Windows failures from raw console output is painful.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL flagged the missing permissions block. Nothing in this workflow writes: checkout needs contents read, and upload-artifact has no GITHUB_TOKEN input - it uses the Actions runtime token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the full test suite on windows-latest against a nats-server built from the tip of main, on every push to main. Windows has never had CI coverage here, and several of the server bugs found through the Java tests over the years were specific to the Windows environment.
The shared synadia-io/workflows install action is bash and unix-only, so this workflow installs the server itself rather than making that action cross platform. It builds nats-server.exe and hands the absolute path to the test harness through the nats_server_path environment variable, which NatsRunnerUtils.getResolvedServerPath() reads - that keeps PATH and PATHEXT out of the picture on a platform where an extensionless binary is not resolvable as a command.
Java 8 only, matching the other builds. No jacoco, coveralls, javadoc or publishing: those are covered on Linux and would only add runtime and failure surface. Test reports upload as an artifact on failure, since triaging Windows failures from raw console output is painful.