Skip to content

Fix failing build caused by concurrent access to externals metadata. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aukevanoost merged 2 commits into from
Feb 9, 2026
Merged

Fix failing build caused by concurrent access to externals metadata. #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdb189e
Fix failing build caused by concurrent access to externals metadata.
Feb 6, 2026
8687036
Fixed imports
Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions packages/core/src/lib/core/build-for-federation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { AbortedError } from '../utils/errors.js';
import type { NormalizedFederationConfig } from '../domain/config/federation-config.contract.js';
import type { NormalizedExternalConfig } from '../domain/config/external-config.contract.js';
import type { BuildParams } from '../domain/core/build-params.contract.js';
import { resolveProjectName } from '../utils/config-utils.js';

export const defaultBuildParams: BuildParams = {
skipMappingsAndExposed: false,
Expand Down Expand Up @@ -49,14 +50,7 @@ export async function buildForFederation(

const exposedInfo = !artifactInfo ? describeExposed(config, fedOptions) : artifactInfo.exposes;

const normalizedCacheFolder = normalizePackageName(config.name);
if (normalizedCacheFolder.length < 1) {
logger.warn(
"Project name in 'federation.config.js' is empty, defaulting to 'shell' cache folder (could collide with other projects in the workspace)."
);
}
const cacheProjectFolder = normalizedCacheFolder.length < 1 ? 'shell' : normalizedCacheFolder;

const cacheProjectFolder = resolveProjectName(config);
const pathToCache = getCachePath(fedOptions.workspaceRoot, cacheProjectFolder);

if (!buildParams.skipShared && sharedCache.externals.length > 0) {
Expand Down
13 changes: 8 additions & 5 deletions packages/core/src/lib/core/remove-unused-deps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { getPackageInfo, type PackageInfo } from '../utils/package-info.js';
import { getExternalImports as extractExternalImports } from '../utils/get-external-imports.js';
import { type MappedPath } from '../domain/utils/mapped-path.contract.js';
import { normalizePackageName } from '../utils/normalize.js';
import { resolveProjectName } from '../utils/config-utils.js';

export function removeUnusedDeps(
config: NormalizedFederationConfig,
Expand All @@ -21,7 +22,8 @@ export function removeUnusedDeps(
const usedPackageNames = usedDeps.usedPackageNames;
const usedMappings = usedDeps.usedMappings;

const usedPackageNamesWithTransient = addTransientDeps(usedPackageNames, workspaceRoot);
const projectName = resolveProjectName(config);
const usedPackageNamesWithTransient = addTransientDeps(usedPackageNames, workspaceRoot, projectName);
const filteredShared = filterShared(config, usedPackageNamesWithTransient);

return {
Expand Down Expand Up @@ -73,7 +75,7 @@ function findUsedDeps(
return { usedPackageNames, usedMappings };
}

function addTransientDeps(packages: Set<string>, workspaceRoot: string) {
function addTransientDeps(packages: Set<string>, workspaceRoot: string, projectName: string) {
const packagesAndPeers = new Set<string>([...packages]);
const discovered = new Set<string>(packagesAndPeers);
const stack = [...packagesAndPeers];
Expand All @@ -91,7 +93,7 @@ function addTransientDeps(packages: Set<string>, workspaceRoot: string) {
continue;
}

const peerDeps = getExternalImports(pInfo, workspaceRoot);
const peerDeps = getExternalImports(pInfo, workspaceRoot, projectName);

for (const peerDep of peerDeps) {
if (!discovered.has(peerDep)) {
Expand All @@ -104,12 +106,13 @@ function addTransientDeps(packages: Set<string>, workspaceRoot: string) {
return packagesAndPeers;
}

function getExternalImports(pInfo: PackageInfo, workspaceRoot: string) {
function getExternalImports(pInfo: PackageInfo, workspaceRoot: string, projectName: string) {
const encodedPackageName = normalizePackageName(pInfo.packageName);
const cacheFileName = `${encodedPackageName}-${pInfo.version}.deps.json`;
const cachePath = path.join(
workspaceRoot,
'node_modules/.cache/native-federation/_externals-metadata'
'node_modules/.cache/native-federation/_externals-metadata',
projectName
);
const cacheFilePath = path.join(cachePath, cacheFileName);

Expand Down
14 changes: 14 additions & 0 deletions packages/core/src/lib/utils/config-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { NormalizedFederationConfig } from '../domain/config/federation-config.contract.js';
import { logger } from './logger.js';
import { normalizePackageName } from './normalize.js';

export function resolveProjectName(config: NormalizedFederationConfig): string {
const normalizedProjectName = normalizePackageName(config.name);
if (normalizedProjectName.length < 1) {
logger.warn(
"Project name in 'federation.config.js' is empty, defaulting to 'shell' cache folder (could collide with other projects in the workspace).",
);
}

return normalizedProjectName.length < 1 ? 'shell' : normalizedProjectName;
}