Skip to content

Better file reading - #1

Open
Cinojose wants to merge 2 commits into
natesales:mainfrom
Cinojose:better_file_reading
Open

Better file reading#1
Cinojose wants to merge 2 commits into
natesales:mainfrom
Cinojose:better_file_reading

Conversation

@Cinojose

Copy link
Copy Markdown

Fixing a couple of issues

  1. Time parsing, some can be 8digits and it fails
  2. Latest guide says Time is not present in the jsonl file structure
  3. Exporter fails when the jsonl file gets rotated, adding a support for live tail

I've been running this patch for sometime and so far it works well.

Thanks for the exporter btw 👍

kotloki added a commit to kotloki/sfptpd-exporter that referenced this pull request Oct 28, 2024
Reduce message master clock time parse error.
@abower-amd

Copy link
Copy Markdown

Hi @Cinojose,

With many thanks to @natesales for leading the way with this exporter, we have now built OpenMetrics stats exporting directly into sfptpd. There are some differences in our implementation. Please do take a look, give it a try and let us know if you have any suggestions for changes.

@Cinojose

Copy link
Copy Markdown
Author

@abower-amd great news! let me play around with the new sfptpd and let you know how it goes.

@abower-amd

abower-amd commented Mar 21, 2025

Copy link
Copy Markdown

@abower-amd great news! let me play around with the new sfptpd and let you know how it goes.

Great @Cinojose - thanks for letting us know, I hope it works well for you! Do let us know on the repository if you have any feedback.

Today we've also pushed built-in TCP listener support so you don't need to proxy the unix domain socket. You need to enable this with, for example, openmetrics_tcp [::] or openmetrics_tcp 127.0.0.1. You can specify an ACL but probably a good idea to use a firewall if exporting TCP directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants