Concurrency tester#6
Open
nat-brown wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test for simultaneous writes to and reads from the action counter. The solution to this was far trickier than the concurrent write only, as we can't use an external lock to test it without masking the lock underneath. The solution was to take advantage of the lock interface for the DataStore and use that to indicate when it's safe to collect data over a channel. Since the Counter was locked anyway, this just extends the time it sits "under" a lock, preserving behavior.
On my machine, this test averages 95,000 reads and writes respectively in the 1 second timeframe. When I remove the lock calls from Counter, this test triggered a warning from
go test -raceand failed its assertions. It triggered a warning fromgo test -racewhen I removed the read lock call from Counter as well, although I wasn't able to get it to fail. Such is the nature of race conditions.