[nasa/nos3#838] OpenC3 Gem Autoloading and Python Scripting#860
Open
kevincbruce wants to merge 9 commits into
Open
[nasa/nos3#838] OpenC3 Gem Autoloading and Python Scripting#860kevincbruce wants to merge 9 commits into
kevincbruce wants to merge 9 commits into
Conversation
…cripts in python (may need further updates)
…erly cleaned and regenerated; however, missing api key is blocking upload to openc3
…rs, rebuild, and load the gem; still not detecting scripts/procedures to pack into the gem
…ibs preprocessed as modules, and 42truthsim to link to its interface correctly (links to 42, not to openc3)
…/device test in OpenC3 (if it is working in base cosmos); fixed gem autoload to be robust. fixed gem generation to handle python so it can be globbed loaded for scripts; need to fix bus bridge for device test and ast
…s for Sim Bridge into separate target as done in COSMOS 4.5; Verified tests execute successfully (note, need to manually renable radio after test to work at the moment, it seems).
… flushing/requests for data back in due to speed increase, plus some extra waits and the like
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #860 +/- ##
=======================================
Coverage 72.06% 72.06%
=======================================
Files 761 761
Lines 91123 91123
Branches 7289 7289
=======================================
Hits 65668 65668
Misses 25455 25455 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Seeks to greatly improve OpenC3 COSMOS 6.3.0 integration into NOS3 with the following major updates:
The biggest changes are to the gsw_openc3_clean/build/launch.sh files, the addition of python versions of the sample_lib, sample_test, sample_app_test, sample_ast_test, and sample_device_test files, and minor updates to the nos3_simulator.xml (commented line for easy switching between COSMOS 4.5 and COSMOS 6.3 settings for truth42sim interface).
How to test?
git pullgit checkout nos3#838-openc3-scripting,git submodule sync,git submodule update --init --recursivedev/1.7.5version of the containers (particularly 42), run amake uninstallandmake prepnos3-mission.xmland update line 12 to openc3nos3-simulator.xmland comment out line 518 and uncomment line 519 (so your cosmos hostname for truth42sim is set toactive-gsto hook to the proper COSMOS 6.3 container). I have tested with the radio set to occulted and delay on. System tests do not use radio, so should not effect them, but did verify the radio line of sight feature works in openc3's radio interface.make clean,make config,make,make launchupload successfulor similar message, rather than anupload failure. Then, wait several minutes until all your interfaces show up as connected in the Command Telemetry Server tab of OpenC3 (may require refreshes to see, and a refresh once all interfaces (and thus microservices, as the interfaces load last) are loaded, or else some options may not show up in the menu/drop down on the left side.Script Runnertab, in the file menu selectOpen File, and navigate toSAMPLE_DEBUG/scripts/sample_test.py(note, the ones in SAMPLE_RADIO should work as well, but will use SAMPLE_DEBUG, not the radio).Start. Verify the test runs successfully without errors. Run a few more times to verify.make stopto bring things downmake launchto verify it launches again without attempting to overwrite the existing gem file. Feel free to test functionality again once it is up. It should come up much quicker with the gem already set up.make stopto bring NOS3 downSubmodule PRs and actions prior to closing this:
Closes #838