Skip to content

300 assess sim blackboard vs separate ipc connections 5#785

Merged
zlynch2 merged 23 commits into
devfrom
300-assess-sim-blackboard-vs-separate-ipc-connections-5
Sep 24, 2025
Merged

300 assess sim blackboard vs separate ipc connections 5#785
zlynch2 merged 23 commits into
devfrom
300-assess-sim-blackboard-vs-separate-ipc-connections-5

Conversation

@msuder

@msuder msuder commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Summary of PR goals.

How to test?

  • cp cfg/InOut/Inp_IPC.shmem.txt cfg/InOut/Inp_IPC.txt
  • cp cfg/sims/nos3-simulator.shmem.xml cfg/sims/nos3-simulator.xml
  • Execute scenarios from https://nos3.readthedocs.io/en/latest/Home.html and verify they work.
  • Remmber to uncomment blackboard sim from fsw_cfs_launch.sh

Submodule PRs and actions prior to closing this:

Closes #300.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.56%. Comparing base (62a0a4f) to head (dea0195).
⚠️ Report is 20 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #785      +/-   ##
==========================================
- Coverage   73.64%   73.56%   -0.08%     
==========================================
  Files         761      761              
  Lines       93972    94078     +106     
  Branches     7064     7130      +66     
==========================================
+ Hits        69203    69206       +3     
- Misses      24769    24872     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zlynch2 zlynch2 changed the base branch from dev to docs_pdf September 22, 2025 15:54
@zlynch2 zlynch2 changed the base branch from docs_pdf to dev September 22, 2025 15:54
@zlynch2

zlynch2 commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

getting multiple errors

image

@zlynch2 zlynch2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, ran through scenarios with sim blackboard. Note, need to uncomment the blackboard sim in fsw_cfs_launch.sh after editing configuration for sims and 42

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Nominal Operations and a few other COSMOS commands, plus some of the tests in the test runner. Everything worked, so approving.

@zlynch2 zlynch2 merged commit 5dd290f into dev Sep 24, 2025
@zlynch2 zlynch2 deleted the 300-assess-sim-blackboard-vs-separate-ipc-connections-5 branch September 29, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants