Implement a reset inside __clone method to avoid headers duplication - #40
Open
ajibarra wants to merge 1 commit into
Open
Implement a reset inside __clone method to avoid headers duplication#40ajibarra wants to merge 1 commit into
ajibarra wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Cake4, Mailer class clone transport before executing deliver method, then it restores the transport instance. When MailgunTransport is clone, the FormData instance in _formData property is shared between the two instances (original and clone) so even when _reset is called after sending email, the cloned instance keeps the previous _formData generating emails with multiple to, subject and from headers.
Calling _reset in new instance fixes the issue