Skip to content

fix: Remove unsupported environment variables - #7

Merged
stormcat24 merged 1 commit into
mainfrom
fix/remove-unsupported-env-vars
Oct 6, 2025
Merged

fix: Remove unsupported environment variables#7
stormcat24 merged 1 commit into
mainfrom
fix/remove-unsupported-env-vars

Conversation

@stormcat24

Copy link
Copy Markdown
Member

Summary

Removed environment variables that are not supported by KECS core.

Problem

The action was exporting environment variables that have no corresponding support in KECS:

  • KECS_ADMIN_ENDPOINT - Not used by KECS
  • KECS_INSTANCE - Not used by KECS

These were action-specific variables that could mislead users into thinking KECS supports them.

Solution

Removed unsupported environment variables. Users should use outputs instead:

  • ${{ steps.kecs.outputs.admin-endpoint }} instead of $KECS_ADMIN_ENDPOINT
  • ${{ steps.kecs.outputs.instance-name }} instead of $KECS_INSTANCE

Supported Environment Variables

The action now exports only officially supported environment variables:

  • AWS_ENDPOINT_URL - For AWS CLI (points to KECS API)
  • KECS_ENDPOINT - For direct API access (supported by KECS config)
  • KUBECONFIG - For kubectl access

Changes

  • action.yml: Removed KECS_ADMIN_ENDPOINT and KECS_INSTANCE exports
  • README.md: Updated environment variables documentation
  • test-setup.yml: Removed verification of unsupported environment variables

Breaking Change

⚠️ Minor breaking change: If users were relying on $KECS_ADMIN_ENDPOINT or $KECS_INSTANCE environment variables, they should switch to using outputs:

# Before
- run: echo "Admin: $KECS_ADMIN_ENDPOINT"
- run: echo "Instance: $KECS_INSTANCE"

# After
- run: echo "Admin: ${{ steps.kecs.outputs.admin-endpoint }}"
- run: echo "Instance: ${{ steps.kecs.outputs.instance-name }}"

However, this is unlikely to affect users since these variables were not documented as KECS-supported features.

🤖 Generated with Claude Code

Removed environment variables that are not needed or supported by KECS:
- KECS_ADMIN_ENDPOINT (not used by KECS)
- KECS_INSTANCE (not used by KECS)
- KECS_ENDPOINT (redundant, users should use outputs)

Rationale:
- AWS_ENDPOINT_URL is sufficient for AWS CLI usage
- KUBECONFIG is sufficient for kubectl access
- For direct API access, users can use outputs:
  - steps.kecs.outputs.endpoint
  - steps.kecs.outputs.admin-endpoint
  - steps.kecs.outputs.instance-name

This simplifies the action and prevents confusion about which
environment variables are officially supported by KECS.

Updated:
- action.yml: Export only AWS_ENDPOINT_URL and KUBECONFIG
- README.md: Updated env var documentation with outputs guidance
- test-setup.yml: Removed verification of removed env vars

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@stormcat24
stormcat24 force-pushed the fix/remove-unsupported-env-vars branch from e31820d to b3614ef Compare October 6, 2025 01:31
@stormcat24
stormcat24 merged commit cc91f88 into main Oct 6, 2025
11 checks passed
@stormcat24
stormcat24 deleted the fix/remove-unsupported-env-vars branch October 6, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant