fix: Remove unsupported environment variables - #7
Merged
Conversation
Removed environment variables that are not needed or supported by KECS: - KECS_ADMIN_ENDPOINT (not used by KECS) - KECS_INSTANCE (not used by KECS) - KECS_ENDPOINT (redundant, users should use outputs) Rationale: - AWS_ENDPOINT_URL is sufficient for AWS CLI usage - KUBECONFIG is sufficient for kubectl access - For direct API access, users can use outputs: - steps.kecs.outputs.endpoint - steps.kecs.outputs.admin-endpoint - steps.kecs.outputs.instance-name This simplifies the action and prevents confusion about which environment variables are officially supported by KECS. Updated: - action.yml: Export only AWS_ENDPOINT_URL and KUBECONFIG - README.md: Updated env var documentation with outputs guidance - test-setup.yml: Removed verification of removed env vars 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
stormcat24
force-pushed
the
fix/remove-unsupported-env-vars
branch
from
October 6, 2025 01:31
e31820d to
b3614ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed environment variables that are not supported by KECS core.
Problem
The action was exporting environment variables that have no corresponding support in KECS:
KECS_ADMIN_ENDPOINT- Not used by KECSKECS_INSTANCE- Not used by KECSThese were action-specific variables that could mislead users into thinking KECS supports them.
Solution
Removed unsupported environment variables. Users should use outputs instead:
${{ steps.kecs.outputs.admin-endpoint }}instead of$KECS_ADMIN_ENDPOINT${{ steps.kecs.outputs.instance-name }}instead of$KECS_INSTANCESupported Environment Variables
The action now exports only officially supported environment variables:
AWS_ENDPOINT_URL- For AWS CLI (points to KECS API)KECS_ENDPOINT- For direct API access (supported by KECS config)KUBECONFIG- For kubectl accessChanges
KECS_ADMIN_ENDPOINTandKECS_INSTANCEexportsBreaking Change
$KECS_ADMIN_ENDPOINTor$KECS_INSTANCEenvironment variables, they should switch to using outputs:However, this is unlikely to affect users since these variables were not documented as KECS-supported features.
🤖 Generated with Claude Code