Skip to content

update Files and the zip - #3

Draft
renanbazinin wants to merge 1 commit into
nand2tetris:mainfrom
renanbazinin:updateZipAndFolders
Draft

update Files and the zip#3
renanbazinin wants to merge 1 commit into
nand2tetris:mainfrom
renanbazinin:updateZipAndFolders

Conversation

@renanbazinin

Copy link
Copy Markdown
Contributor

Shimon asked me to update the project repository with the latest files.
He also asked me to upload the ZIP file and use that ZIP in GitHub as the official download link for the projects folder.

Personally, I think we should use GitHub Releases, as they provide easier access for downloading the folder. (Also as zip)

@renanbazinin

Copy link
Copy Markdown
Contributor Author

But we can also use the raw link version like: 🤷🏻
https://github.com/renanbazinin/projects/raw/refs/heads/updateZipAndFolders/projects.zip

So there might be no need to create a Release.

@DavidSouther

Copy link
Copy Markdown
Contributor

Why is every file getting touched? The 0 prefix on the folders is to keep project files sorted when viewing them. I understand Shimon's argument that this is confusing to students, but I have not had that same experience when teaching the course (albeit I haven't taught it as much as Shimon).

If that is necessary, do the change in a way that preserves git history, as moves rather than as adds and deletes.

Finally, do not store .zip files in git repositories. Use GitHub actions to create the zip file when preparing a new release.

https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-large-files-on-github#distributing-large-binaries

There's should be two PRs- one to rename folders (if necessary, I really do think it's a degradation to remove the leading numeric prefix), and one to add the GitHub action to create the zip file.

@renanbazinin
renanbazinin marked this pull request as draft November 28, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants