Skip to content

fix: stabilize guided import branch#727

Open
jaeyunha wants to merge 1 commit into
stagingfrom
issue-559-parity-upgrade-import-export-to-gu
Open

fix: stabilize guided import branch#727
jaeyunha wants to merge 1 commit into
stagingfrom
issue-559-parity-upgrade-import-export-to-gu

Conversation

@jaeyunha

Copy link
Copy Markdown
Member

Summary

  • keep the guided GitHub import branch clean on top of staging
  • renumber provider migration files after staging gained customer request migrations
  • repair the integrations settings merge so provider setup tests parse and Google Sheets/Front/Zendesk setup flows stay visible

Verification

  • pnpm --filter @exponential/web exec vitest run tests/import-export-view.test.tsx
  • pnpm --filter @exponential/web exec vitest run tests/integrations-view.test.tsx
  • node scripts/check-migrations.mjs
  • make check (blocked: web typecheck still imports removed Better Auth/Drizzle modules and missing subscribeToSync export outside this diff)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

CREATE TABLE IF NOT EXISTS customer (

P2 Badge Preserve existing migration filenames

Renaming this migration (and the sibling 0010/0011 renames in this diff) breaks the migration contract: apps/api/cmd/migrate records applied migrations by filename, and packages/proto/migrations/README.md explicitly says not to rename migrations that may have been applied. On any database that already has 0010_customer_requests_gong.sql recorded, 0012_customer_requests_gong.sql is treated as unapplied and executed again, leaving divergent migration history; keep historical filenames and adjust the guard with an explicit exception/alias instead.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1043 to +1047
const canAct =
props.integration.actions.canConnect ||
props.integration.actions.canReconnect ||
props.integration.status === "configuration_required" ||
props.integration.status === "not_connected";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate setup forms on server-provided actions

For non-admin/non-owner users, integrationActions returns canConnect/canReconnect false even though uninstalled providers still have status: "not_connected". Because canAct also trusts status, the catalog now renders GitLab/Jira/Front/Zendesk credential forms and enabled setup buttons to users who cannot manage integrations; submitting only fails with a 403 after they enter secrets. Gate these forms on the server-provided action flags rather than status alone.

Useful? React with 👍 / 👎.

Comment on lines +1079 to +1080
<SetupButton
disabled={props.pendingProvider === "google_sheets"}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Disable Google Sheets creation with no export scopes

The previous catalog button was disabled when issues, projects, and initiatives were all unchecked, matching GoogleSheetsConnect's hasGoogleSheetsScope validation. This new button stays enabled with all three scopes false, so the UI sends a request that the API rejects with “Select at least one Google Sheets export scope” instead of preventing the invalid flow; keep the prior all-scopes-empty disabled condition here.

Useful? React with 👍 / 👎.

@jaeyunha

Copy link
Copy Markdown
Member Author

Controller disposition for current head 27e93b1: validation-blocked; do not merge as-is.

Current blockers:

Required before merge: rebuild/rebase on current origin/staging, preserve existing migration filenames, keep only the intended #559 slice, and rerun focused web/import-export/integrations plus migration checks.

@jaeyunha

Copy link
Copy Markdown
Member Author

Controller validation: blocked. This PR currently conflicts with staging, renames already-landed migration files, and only covers a stabilization slice of #559 rather than the full guided import scope. Do not merge as-is. Next controller action is to salvage only legitimate unlanded #559 deltas onto a fresh branch from current origin/staging, with no migration renames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant