fix: complete customer request parity slice#725
Conversation
Union-merged router routes (customer-requests.csv + figma-sources refresh) and openapi.gen.go params structs (GithubSetupCallback + IngestGitHubWebhook + IntercomOAuthCallback). openapi.yaml and SDK auto-merged cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…dd-customer-requests-data # Conflicts: # apps/api/internal/projects/handler.go
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8ebafbf09
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,110 @@ | |||
| -- First-class customer request entities and links to product work. | |||
There was a problem hiding this comment.
Keep existing migration filenames unchanged
Adding the new customer-request migration at 0011 required this commit to rename previously committed migrations such as 0011_agent_runs.sql to 0017_agent_runs.sql. The migration runner records applied migrations by filename, and packages/proto/migrations/README.md explicitly says not to rename applied migrations, so any environment that has already run the old filenames will treat the renamed files as brand-new migrations and re-run them on deploy. Use the next unused filename for this new migration and leave the existing migration filenames intact.
Useful? React with 👍 / 👎.
| <SidebarLink | ||
| href="/customers" | ||
| label="Customers" |
There was a problem hiding this comment.
Register customers as a workspace route
This link is intended to open the new workspace customer UI, but withWorkspaceSlug only prefixes paths whose first segment is in appRoutePrefixes, and customers is still only treated as a public route. As a result, clicking the new Customers sidebar entry in a workspace sends users to /customers (the marketing page) instead of /{workspaceSlug}/customers; the same applies to customer detail links built with /customers/.... Add the customer route to the workspace route handling so these links stay scoped to the active workspace.
Useful? React with 👍 / 👎.
|
Controller disposition for current head Evidence:
Required before merge: port only the unlanded customer-request parity delta onto current |
Summary
Validation
Known blockers