Skip to content

added udf1 field in create order request#1358

Open
Hari-Krishna-Dupaguntla wants to merge 1 commit into
mainfrom
added_udf
Open

added udf1 field in create order request#1358
Hari-Krishna-Dupaguntla wants to merge 1 commit into
mainfrom
added_udf

Conversation

@Hari-Krishna-Dupaguntla

@Hari-Krishna-Dupaguntla Hari-Krishna-Dupaguntla commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code and addressed linter errors ./dev/format-all-files.sh
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Summary by CodeRabbit

  • New Features
    • Enhanced payment processing to support additional custom fields in payment orders for improved payment flexibility and integration capabilities.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3f94f369-1fdb-44fc-af49-0c16be3bfeb9

📥 Commits

Reviewing files that changed from the base of the PR and between 38e376f and 61d9d8d.

📒 Files selected for processing (4)
  • lib/mobility-core/src/Kernel/External/Payment/Interface.hs
  • lib/mobility-core/src/Kernel/External/Payment/Interface/Juspay.hs
  • lib/mobility-core/src/Kernel/External/Payment/Interface/Types.hs
  • lib/mobility-core/src/Kernel/External/Payment/Juspay/Types/CreateOrder.hs

Walkthrough

Adds an optional udf1 :: Maybe Text field to CreateOrderReq and CreatePaymentReq in the shared interface types, to the Juspay wire-level CreateOrderReq, and propagates the value through mkCreateOrderReq and both the JuspayConfig and PaytmEDCConfig branches of createPayment.

Changes

udf1 field plumbing across payment create-order path

Layer / File(s) Summary
Interface and wire type contracts for udf1
lib/mobility-core/src/Kernel/External/Payment/Interface/Types.hs, lib/mobility-core/src/Kernel/External/Payment/Juspay/Types/CreateOrder.hs
CreateOrderReq and CreatePaymentReq in the interface types module each gain udf1 :: Maybe Text; the Juspay wire-level CreateOrderReq gains the same field.
udf1 mapping in mkCreateOrderReq and createPayment dispatch
lib/mobility-core/src/Kernel/External/Payment/Interface/Juspay.hs, lib/mobility-core/src/Kernel/External/Payment/Interface.hs
mkCreateOrderReq maps the new field into the Juspay record; createPayment sets udf1 = req.udf1 in both the JuspayConfig and PaytmEDCConfig record constructions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • nammayatri/shared-kernel#1288: Added paymentFilter plumbing through the same createPayment/mkCreateOrderReq path and the same CreateOrderReq/CreatePaymentReq types that this PR extends with udf1.

Suggested reviewers

  • khuzema786
  • Vignesh-772

Poem

🐇 A field called udf1 hops into the req,
Through Juspay and PaytmEDC, making its way,
Maybe Text, so gentle, optional and light,
It wiggles through records with fluffy delight.
The order is placed, and the bunny says "hooray!" 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a udf1 field to create order request structures across multiple modules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch added_udf

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot requested review from Vignesh-772 and khuzema786 June 16, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants