Map Zendesk unsupported ticket errors to 400 instead of 500#1353
Draft
vijaygupta18 wants to merge 1 commit into
Draft
Map Zendesk unsupported ticket errors to 400 instead of 500#1353vijaygupta18 wants to merge 1 commit into
vijaygupta18 wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Argus proposed fix
Fix confidence: HIGH (score 0.85)
Reasons: RCA high-confidence, exact line identified, confirmed pattern matched, localized diff (1f/12l)
Root cause
The kapturePullTicket and related ticket interface functions in shared-kernel unconditionally throw InternalError when ZendeskConfig is active. InternalError maps to HTTP 500, which inflates ALB 5xx counts even though this is a configuration/client-side mismatch, not a server failure. Changing to InvalidRequest maps it to HTTP 400, removing it from 5xx alerting.
Evidence
see RCA
Rollback
Revert the commit or change InvalidRequest back to InternalError in lib/mobility-core/src/Kernel/External/Ticket/Interface.hs
Draft PR — review and merge manually. Generated by Argus.