Skip to content

Map Zendesk unsupported ticket errors to 400 instead of 500#1353

Draft
vijaygupta18 wants to merge 1 commit into
mainfrom
argus/fix-s1781449486
Draft

Map Zendesk unsupported ticket errors to 400 instead of 500#1353
vijaygupta18 wants to merge 1 commit into
mainfrom
argus/fix-s1781449486

Conversation

@vijaygupta18

Copy link
Copy Markdown
Member

🤖 Argus proposed fix

Fix confidence: HIGH (score 0.85)
Reasons: RCA high-confidence, exact line identified, confirmed pattern matched, localized diff (1f/12l)

Root cause

The kapturePullTicket and related ticket interface functions in shared-kernel unconditionally throw InternalError when ZendeskConfig is active. InternalError maps to HTTP 500, which inflates ALB 5xx counts even though this is a configuration/client-side mismatch, not a server failure. Changing to InvalidRequest maps it to HTTP 400, removing it from 5xx alerting.

Evidence

see RCA

Rollback

Revert the commit or change InvalidRequest back to InternalError in lib/mobility-core/src/Kernel/External/Ticket/Interface.hs


Draft PR — review and merge manually. Generated by Argus.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f1da3864-0d14-4a10-84d8-cde22a26da18

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch argus/fix-s1781449486

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant