Skip to content

backend/fix:- Returing empty response in case of kapture when config … #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kuldeepkumawat144 wants to merge 1 commit into
base: prodHotPush-BAP
Choose a base branch
from
Open

backend/fix:- Returing empty response in case of kapture when config … #1348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions lib/mobility-core/src/Kernel/External/Ticket/Interface.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ import qualified Kernel.External.Ticket.Kapture.Types as KT
import Kernel.Prelude
import Kernel.Tools.Metrics.CoreMetrics (CoreMetrics)
import Kernel.Types.Common
import Kernel.Types.Error (GenericError (InternalError))
import Kernel.Utils.Error.Throwing (throwError)
import Kernel.Utils.Servant.Client

createTicket ::
Expand Down Expand Up @@ -71,7 +69,7 @@ addAndUpdateKaptureCustomer ::
m KT.KaptureCustomerResp
addAndUpdateKaptureCustomer serviceConfig req = case serviceConfig of
KaptureConfig cfg -> Kapture.addAndUpdateKaptureCustomer cfg req
ZendeskConfig _ -> throwError $ InternalError "addAndUpdateKaptureCustomer not supported for Zendesk"
ZendeskConfig _ -> pure KT.KaptureCustomerResp {message = "Not applicable for Zendesk", status = "ok", kaptureCustomerId = ""}

kaptureEncryption ::
( EncFlow m r,
Expand All @@ -84,7 +82,7 @@ kaptureEncryption ::
m KT.KaptureEncryptionResp
kaptureEncryption serviceConfig req = case serviceConfig of
KaptureConfig cfg -> Kapture.kaptureEncryption cfg req
ZendeskConfig _ -> throwError $ InternalError "kaptureEncryption not supported for Zendesk"
ZendeskConfig _ -> pure KT.KaptureEncryptionResp {success = True, encrytedCc = "", encryptedIv = ""}

kapturePullTicket ::
( EncFlow m r,
Expand All @@ -97,7 +95,7 @@ kapturePullTicket ::
m KT.KapturePullTicketResp
kapturePullTicket serviceConfig req = case serviceConfig of
KaptureConfig cfg -> Kapture.kapturePullTicket cfg req
ZendeskConfig _ -> throwError $ InternalError "kapturePullTicket not supported for Zendesk"
ZendeskConfig _ -> pure KT.KapturePullTicketResp {totalCount = Just 0, message = [], status = "ok"}

kaptureGetTicket ::
( EncFlow m r,
Expand All @@ -110,7 +108,7 @@ kaptureGetTicket ::
m [KT.GetTicketResp]
kaptureGetTicket serviceConfig req = case serviceConfig of
KaptureConfig cfg -> Kapture.kaptureGetTicket cfg req
ZendeskConfig _ -> throwError $ InternalError "kaptureGetTicket not supported for Zendesk"
ZendeskConfig _ -> pure []

getTicketStatus ::
( EncFlow m r,
Expand All @@ -123,4 +121,4 @@ getTicketStatus ::
m [KT.GetTicketStatusResp]
getTicketStatus serviceConfig req = case serviceConfig of
KaptureConfig cfg -> Kapture.getTicketStatus cfg req
ZendeskConfig _ -> throwError $ InternalError "getTicketStatus not supported for Zendesk"
ZendeskConfig _ -> pure []