RyzenSMU: Remove unnecessary io space map in main#73
Open
irusanov wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know how I messed this up, but the current version of the module has wrong logic as it maps the space on module load, which is really not desired. Not only this, but it would require pci mutex lock on module load due to the
get_pm_table_versionwhich sends a smu command.ioctl_read_pm_table, but map only once and unmap on module unload in comparison with older versions of the module. This seems the correct approach for me as some clients might not need the pm table functionality at all.g_table_sizeglobal var as that's not really needed at the moment, since the whole page window (PAGE_SIZE) is mapped. The real table size is not fetched.Sorry for the possible incovenience caused for other projects using this module.