Skip to content

Add option to show single progress bar for all workers#239

Closed
puglial wants to merge 9 commits into
nalepae:masterfrom
puglial:patch-1
Closed

Add option to show single progress bar for all workers#239
puglial wants to merge 9 commits into
nalepae:masterfrom
puglial:patch-1

Conversation

@puglial

@puglial puglial commented May 23, 2023

Copy link
Copy Markdown

Not sure why ApolloBian didn't reply further to the PR(#203) but i'm here to make sure this change is merged.

@codecov

codecov Bot commented May 23, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.55%. Comparing base (46fc0e5) to head (545ac80).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pandarallel/progress_bars.py 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   91.37%   90.55%   -0.83%     
==========================================
  Files          12       12              
  Lines         580      593      +13     
==========================================
+ Hits          530      537       +7     
- Misses         50       56       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@t-muser

t-muser commented May 23, 2023

Copy link
Copy Markdown
Collaborator

Hi @lpuglia, thanks for taking care of this. Could you also make sure this change is covered by adding a fixture for the single bar option (see e.g. this)?

Comment thread pandarallel/core.py Outdated
@puglial

puglial commented May 23, 2023

Copy link
Copy Markdown
Author

@Till-M should I add tests for codecov?

@t-muser

t-muser commented May 23, 2023

Copy link
Copy Markdown
Collaborator

The uncovered lines seem to only relate to the use in notebooks, I don't know any convenient way to test them. If you have something, feel free to let me know. I will try to test them manually by tomorrow so that I can merge this with no further delay.

@t-muser t-muser requested review from nalepae and t-muser May 23, 2023 11:26

@t-muser t-muser left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lpuglia,

I tested it, and it works, so the PR looks good in general to me.

Two small changes:
I think the code should either use single_bar or single_progress_bar, not both. And I would also ask you to briefly document the functionality in the user guide.

@puglial

puglial commented Jun 22, 2023

Copy link
Copy Markdown
Author

@Till-M done.

By the way, it looks fine in both ipywidget
image
and text mode:
image

@t-muser

t-muser commented Jun 26, 2023

Copy link
Copy Markdown
Collaborator

Hi @lpuglia,

thanks for changing the function argument name. Could you also add a small line in the documentation, specifically here updating the function parameter description?

Comment thread pandarallel/core.py
if use_memory_fs
else parallelize_with_pipe
)
parallelize = partial(parallelize, single_bar=single_bar)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO instead it would be better to supply the argument in lines 528 onward as it is currently done with the arguments of parallelize. @nalepae any opinion?

@singhsidhukuldeep

Copy link
Copy Markdown

This is feature is so important that this PR almost brought a tear in my eyes
Please merge this friends @lpuglia @Till-M @ApolloBian @synapticarbors @bra-fsn @nalepae

@puglial

puglial commented Dec 22, 2025

Copy link
Copy Markdown
Author

@nalepae can you approve?

@puglial puglial closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants