fix: use isTRUE() for compare_arms_option checks - #5
Merged
Conversation
Bare `if (compare_arms_option)` crashes when passed the string "none" (as shown in the README single-arm example). Replace all three bare conditionals with `isTRUE(compare_arms_option)`, consistent with interim_logic.R:64 which already uses this pattern. Closes #4 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if (compare_arms_option)withisTRUE(compare_arms_option)at three locations inR/simulation_driver.R(lines 549, 624, 645)compare_arms_option = "none"as shown in the README single-arm exampleinterim_logic.R:64which already usesisTRUE()Test plan
compare_arms_option = "none"runs without errorcompare_arms_option = FALSE(single-arm, logical) still workscompare_arms_option = TRUE(multi-arm) still worksCloses #4
🤖 Generated with Claude Code