Fix: Safely skips comma-separated media types in CSS parser#641
Open
ashishkataria86 wants to merge 1 commit into
Open
Fix: Safely skips comma-separated media types in CSS parser#641ashishkataria86 wants to merge 1 commit into
ashishkataria86 wants to merge 1 commit into
Conversation
The current fix only improves stability (treat this as an enhancement) - With this fix, AntiSamy no longer fails or strips the entire <style> block when encountering comma-separated media rules. Instead, it safely preserves valid parts and skips the rest.
Collaborator
|
@spassarop - Have you looked at this PR yet? |
Collaborator
|
@ashishkataria86 Could you add a test that proves stability and the behavior enhancement? |
Collaborator
|
@ashishkataria86 - nudge. Can you add the test changes that @spassarop has requested? |
Collaborator
|
@ashishkataria86 - Are you going to work on the updates @spassarop requested? |
Author
|
@davewichers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current fix only improves stability (treat this as an enhancement) - With this fix, AntiSamy no longer fails or strips the entire <style> block when encountering comma-separated media rules. Instead, it safely preserves valid parts and skips the rest.