Fix motion mode on star adventurer v1#6
Open
raffysommy wants to merge 2 commits into
Open
Conversation
Owner
|
Hi!
I will consider merging your changes but not in the near future. I am
involved in a other very time comsuming task rigth now.
Thanks for your contribution and good luck with your proyect!
El mar, 5 ago 2025 a las 14:43, Raffaele Sommese ***@***.***>)
escribió:
… *Hey,*
First of all, thanks a lot for the project!
I had to make a few changes to get it working with the Star Adventurer v1
(with the advanced firmware), specifically in the set_motion and goto
functions. I also needed to expose the prescaler and status via public
functions for my SAv1 GoTo project
<https://github.com/raffysommy/star-adventurer-goto>.
These changes might not be directly mergeable as they could break
compatibility with other mounts, but if you're able to test them, you might
consider merging (part of) them. :)
------------------------------
You can view, comment on, or merge this pull request online at:
#6
Commit Summary
- b436bf4
<b436bf4>
Fix motion mode on star adventurer, add helper function for T1 preset and
get status
File Changes
(1 file <https://github.com/nachoplus/pysynscan/pull/6/files>)
- *M* synscan/motors.py
<https://github.com/nachoplus/pysynscan/pull/6/files#diff-1ef6807204d42623791a59dbe20e16d890cbff6d4f394519dbd8bf3674648ea9>
(28)
Patch Links:
- https://github.com/nachoplus/pysynscan/pull/6.patch
- https://github.com/nachoplus/pysynscan/pull/6.diff
—
Reply to this email directly, view it on GitHub
<#6>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNHIJWJEZBRVWUKTHUSVJD3MCRGNAVCNFSM6AAAAACDE3VBFCVHI2DSMVQWIX3LMV43ASLTON2WKOZTGI4TEOJXGI4DKMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
First of all, thanks a lot for the project!
I had to make a few changes to get it working with the Star Adventurer v1 (with the advanced firmware), specifically in the
set_motionandgotofunctions. I also needed to expose the prescaler and status via public functions for my SAv1 GoTo project.These changes might not be directly mergeable as they could break compatibility with other mounts, but if you're able to test them, you might consider merging (part of) them. :)