feat: NTFのAI対応 — ExcelテストデータをYAML形式に移行 - #139
Draft
kiyotis wants to merge 26 commits into
Draft
Conversation
…encies Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Also fix COST_OF_GOODS_SOLD value in downloadNormal.yaml (2000.0 -> 2000) to match the integer value stored in the original xlsx. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Manual fix was incorrect — converter bug (integer → float string) should be reported upstream to nablarch-testing-converter, not patched here. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…s to YAML - Add yamlInterpreters list and YamlTestDataParser component to unit-test.xml - Convert 9 remaining .xls entity test data files (dto/form) to YAML using nablarch-testing-converter, placing them alongside test classes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Delete testBeanValidation.yaml for ProjectSearchFormTest (no corresponding test method) - Replace component-ref entries in yamlInterpreters with inline component class definitions for better self-containedness and structural consistency with nablarch-testing-yaml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…or re-conversion - pom.xml: move nablarch-testing-converter from dependency to build plugin with default-cli execution (from=xls, to=yaml, overwrite=true) - restore 15 xlsx/xls files for re-conversion via plugin Re-conversion pending: nablarch-testing-converter fix for duplicate column WARN is required before running mvn nablarch-testing-converter:convert again. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Run mvn nablarch-testing-converter:convert (plugin execution) - Duplicate column 'expectedTable' in ProjectActionRequestTest/updateNormal correctly emitted as WARNING (not error); last column value adopted - Remove 15 xlsx/xls files after successful re-conversion - mvn test: Tests run: 151, Failures: 0 — BUILD SUCCESS Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See steering.