Skip to content

fix: make cancel operation durable — prevent feeders from overwriting CANCELLED status #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChefControl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: make cancel operation durable — prevent feeders from overwriting CANCELLED status #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions feeder/src/job.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ async fn update_job_status(
) -> Result<(), anyhow::Error> {
let q = query(
"MATCH (n:URL {name: $name, http_type: $http_type, current_depth: $current_depth, crawl_id: $crawl_id}) \
WHERE n.job_status <> 'CANCELLED' \
SET n.job_status = $status, n.attempts = $attempts",
)
.param("name", job.name.as_str())
Expand Down Expand Up @@ -371,10 +372,18 @@ pub async fn feeding(
return Ok(false);
}

// Step 6: Batch-create nodes and relationships
// Step 6: Re-check cancellation before creating children.
// This closes the race window where a cancel fires after the initial
// is_cancelled check but before we persist new PENDING children.
if is_cancelled(graph, job).await? {
tracing::info!("Job {} cancelled during processing, skipping child creation", job.name);
return Ok(false);
}

// Step 7: Batch-create nodes and relationships
batch_create_children(graph, job, &children).await?;

// Step 7: Mark COMPLETED
// Step 8: Mark COMPLETED
update_job_status(graph, job, "COMPLETED", job.attempts).await?;
Ok(true)
}