fix: normalize app placeholder variants in app_path() - #2166
Open
raphyabak wants to merge 1 commit into
Open
Conversation
app_path() only stripped a leading "app/" or the configured custom
app folder when the input had an exact, case-sensitive match including
a trailing slash. This left app_path('app'), app_path('App/') and
app_path('App\\') unstripped, producing e.g. 'src/app' instead of
'src' when modules.paths.app_folder is customized.
Normalize backslashes to forward slashes and compare the leading path
segment case-insensitively so all of app/, app, App/, and App\ collapse
to the same base path, matching the default 'app/' case that already
worked.
Fixes nWidart#2152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app_path()only stripped a leadingapp/or the configured custom app folder when the input had an exact, case-sensitive match including a trailing slash. This leftapp_path('app'),app_path('App/'), andapp_path('App\\')unstripped, producing e.g.src/appinstead ofsrcwhenmodules.paths.app_folderis customized — as reported in #2152.App\FooandApp/Fooare handled alike.appand the configured custom app folder, soapp/,app,App/, andApp\all collapse to the same base path (previously only the exactapp/form worked).Fixes #2152
Test plan
app_folderset tosrc.src/appinstead ofsrc) and passes with it.composer pcfrun against the changed files.