fix: prevent fatal error in module_path helper when module not found - #2162
Open
YoussefMansour9 wants to merge 1 commit into
Open
fix: prevent fatal error in module_path helper when module not found#2162YoussefMansour9 wants to merge 1 commit into
YoussefMansour9 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the module_path() helper is called before the module registry is fully resolved during bootstrap (e.g. on NativePHP Android runtime), app("modules")->find($name) returns null, causing a Call to a member function getPath() on null fatal error.
Fix
Add a null check before calling getPath(). If the module is not found, fall back to the default Modules/{name} path.
Related Issue
Closes #2158