Skip to content

Fix rollover-unsafe millis() timeout in scannerGraphic.ino #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TMRh20 merged 2 commits into from
Jun 6, 2026
Merged

Fix rollover-unsafe millis() timeout in scannerGraphic.ino #1073

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b108ee
Initial plan
Copilot Jun 4, 2026
eee89fd
Fix rollover-unsafe millis() timeout in scannerGraphic.ino
Copilot Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/scannerGraphic/scannerGraphic.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,10 @@ void setup(void) {

// set the data rate
#ifdef DEBUGGING
unsigned long inputTimeout = millis() + 7000;
unsigned long inputTimeout = millis();
Serial.print(F("Select your Data Rate. "));
Serial.println(F("Enter '1' for 1Mbps, '2' for 2Mbps, '3' for 250kbps. Defaults to 1 Mbps."));
while (!Serial.available() && millis() < inputTimeout) {
while (!Serial.available() && millis() - inputTimeout < 7000) {
// Wait for user input. Timeout after 7 seconds.
}
char dataRate = !Serial.available() ? '1' : Serial.parseInt();
Expand Down
Loading