Skip to content

feat: use 1 buffer for both SPI TX/RX ops - #1067

Closed
2bndy5 wants to merge 1 commit into
masterfrom
spi-buf
Closed

2bndy5 wants to merge 1 commit into
masterfrom
spi-buf

Conversation

@2bndy5

@2bndy5 2bndy5 commented Apr 4, 2026

Copy link
Copy Markdown
Member

Opening this PR just to see if the compile size is reduced any. I haven't had a chance to properly test this.

@github-actions

github-actions Bot commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Memory usage change @ 525d5c6

Board Flash % RAM for global variables %
arduino:avr:nano 0 - 0 0 - 0 0 - 0 0 - 0
arduino:samd:mkrzero 0 - 0 0 - 0 0 - 0 0 - 0
Click for full report per board

arduino:avr:nano

Sketch Flash % RAM for global variables %
examples/GettingStarted 0 0 0 0
examples/AcknowledgementPayloads 0 0 0 0
examples/ManualAcknowledgements 0 0 0 0
examples/StreamingData 0 0 0 0
examples/MulticeiverDemo 0 0 0 0
examples/InterruptConfigure 0 0 0 0
examples/scanner 0 0 0 0
examples/encodeRadioDetails 0 0 0 0

arduino:samd:mkrzero

Sketch Flash % RAM for global variables %
examples/GettingStarted 0 0 0 0
examples/AcknowledgementPayloads 0 0 0 0
examples/ManualAcknowledgements 0 0 0 0
examples/StreamingData 0 0 0 0
examples/MulticeiverDemo 0 0 0 0
examples/InterruptConfigure 0 0 0 0
examples/scanner 0 0 0 0
examples/encodeRadioDetails 0 0 0 0

@2bndy5

2bndy5 commented Apr 4, 2026

Copy link
Copy Markdown
Member Author

oh, right! the SPI buffers would only affect Pico SDK, Linux, and XMEGA_D3 platforms.

Ok, this doesn't seem worth pursuing now. All those platforms have the extra 33 bytes of memory to spare.

@2bndy5 2bndy5 closed this Apr 4, 2026
@2bndy5
2bndy5 deleted the spi-buf branch April 4, 2026 06:59
@2bndy5

2bndy5 commented Apr 4, 2026

Copy link
Copy Markdown
Member Author

I'm going to clean up some other unused branches. Namely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant