Skip to content

New namespacing issues #1068

Closed
#1069
Closed
New namespacing issues#1068
#1069
Assignees
2bndy5copilot-swe-agent

Description

@TMRh20
TMRh20
opened on Apr 4, 2026

What radio module do you use?

All modules

What driver board(s) do you use?

ESP32 - Heltec Wifi Kit32

If using Linux, what OS are you using?

If using Linux, what RF24 driver did you select?

None

Describe your problem

Attempting to build RF24Ethernet for ESP32, it looks like the new namespacing still requires us to qualify the constants with nRF24L01::

Note

Seems like regression from #1066

What is the RX code?

#include <RF24.h>
#include <RF24Network.h>
#include "RF24Mesh.h"
#include <RF24Ethernet.h>

What is the TX code?

#include <RF24.h>
#include <RF24Network.h>
#include "RF24Mesh.h"
#include <RF24Ethernet.h>

Activity

  1. TMRh20 commented on Apr 4, 2026

    @TMRh20
    TMRh20
    on Apr 4, 2026
    MemberAuthor

    @Copilot Can you qualify all the register constants from nRF24L01.h in RF24.cpp using nRF24L01:: and create a new PR?

  2. 2bndy5
    assigned
    Copilot
    and
    2bndy5
    on Apr 4, 2026
  3. Copilot
    linked a pull request that will close this issuefix: use explicit `nRF24L01::` namespace in RF24.cpp #1069on Apr 4, 2026

  4. 2bndy5 commented on Apr 4, 2026

    @2bndy5
    2bndy5
    on Apr 4, 2026
    Member

    I just assigned this issue to the AI. I found that works better than tagging it arbitrarily.

  5. 2bndy5 commented on Apr 4, 2026

    @2bndy5
    2bndy5
    on Apr 4, 2026
    Member

    watch it work: https://github.com/nRF24/RF24/tasks/21363c49-c9be-4dda-a5df-0f0e38fc0bb2?author=2bndy5

    then point and laugh 🤣

  6. TMRh20 commented on Apr 4, 2026

    @TMRh20
    TMRh20
    on Apr 4, 2026
    MemberAuthor

    Fancy way to Find/Replace lol

  7. 2bndy5
    closed this as completedin #1069on Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions