feat(eventPipeline): let AI summary node reuse a centralized LLM config#2169
Open
cencaogao wants to merge 1 commit into
Open
feat(eventPipeline): let AI summary node reuse a centralized LLM config#2169cencaogao wants to merge 1 commit into
cencaogao wants to merge 1 commit into
Conversation
Add a 'Reuse LLM Config' select to the AI summary processor form. Picking a configured LLM (from /api/n9e/ai-llm-configs) hides and clears the inline url/api_key/model_name fields and drops their required rules, so the node can be saved with just llm_config_id. Leaving it empty keeps the existing inline manual configuration. Uses the absolute form path (prefixNamePath + namePath) for Form.useWatch, matching the existing Relabel processor, so the watch works inside Form.List. Backend: ccfos/nightingale#3199 Signed-off-by: cencaogao <cencaogao@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds support for selecting a centralized, reusable LLM configuration in the AISummary event pipeline processor. Includes a new llm_config_id select field, conditional hiding/required logic for inline url/api_key/model_name fields, prefixNamePath wiring from the parent form, and new English/Chinese locale strings. ChangesCentralized LLM Config Selection in AISummary
Estimated code review effort: 2 (Simple) | ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a 'Reuse LLM Config' select to the AI summary processor form. Picking a configured LLM (from /api/n9e/ai-llm-configs) hides and clears the inline url/api_key/model_name fields and drops their required rules, so the node can be saved with just llm_config_id. Leaving it empty keeps the existing inline manual configuration.
Uses the absolute form path (prefixNamePath + namePath) for Form.useWatch, matching the existing Relabel processor, so the watch works inside Form.List.
Backend: ccfos/nightingale#3199
Summary by CodeRabbit
New Features
Bug Fixes