fix(table): 操作列文字左对齐(整体方案) + 排序/筛选图标间距收紧#2167
Draft
Fiona2016 wants to merge 7 commits into
Draft
Conversation
srm-fe 走查共性问题移植到 n9e/fe(集成构建的 EnhancedTable/theme 以 fe 为准)： - EnhancedTable 检测操作列(dataIndex='operate' 或标题「操作」)→注入 .fc-table-op-column+align:left； style.less .fc-table-op-column 去掉首个内联 link/text 按钮左内边距(class-led)。 - theme/table.less 排序+筛选同列漏斗 margin-left 6px→2px，图标不再离太远/窄列放不下。 对应 srm-fe PR #1033 的同类改动(srm-fe 侧因 integrate.js 不覆盖 fe 的共享组件/主题而不生效)。
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add showQuickJumper:true to the shared usePagination hook so every table that spreads its return value gets the 跳转至第 X 页 input, consistently. Server-side paginated tables reuse the same onChange callback (verified all hook-consuming server-side tables pass total), so no behavior change beyond the added jump input. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…zh title EnhancedTable tagged hand-written action columns via col.title === '操作', matching only the Chinese literal — under any other locale the op-column left-align silently stopped working. Detect via col.key === 'operate' (or dataIndex) instead. This is the fe copy that ships in the integration build; all fe op columns already use rowActions or dataIndex='operate', so nothing regresses. Mirrors the srm-fe change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Cap the EllipsisText tooltip at maxHeight 400 with overflow auto so very long cell text scrolls inside the tooltip instead of overflowing the viewport. This is the fe copy that ships in the integration build; mirrors the srm-fe change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified branch
feat-table-fix-0708(shared across the three repos). Two commonstyling issues surfaced during the srm-fe table review; since the integration build takes
EnhancedTable/theme from this repo, they are fixed here.
the action column and injects
.fc-table-op-column+align: 'left';style.lessremovesthe left padding of the first inline link/text button (class-led selector).
theme/table.less.ant-table-filter-triggermargin-left6px -> 2px.Additional changes (global — please note)
usePagination: enableshowQuickJumperglobally (affects all ~61 tables using this hook).when the datasource is enabled (previously hidden), for UX consistency.
Known follow-up
'操作', so the alignmentapplies reliably only in the zh locale; a locale-independent signal is preferable.
Verification: 9111 build SUCCESS; filter-trigger margin = 2px;
.fc-table-op-columnpresent.🤖 Generated with Claude Code