Add RCC6 Wi-Fi AP companion WebUI - #2
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2fd6c8bfd1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (_session == Session::HTTP && | ||
| static_cast<uint32_t>(millis() - _http_last_activity) >= HTTP_SESSION_TIMEOUT_MS && | ||
| _recv_queue.empty() && _send_queue.empty() && _http_inflight_seq == 0) { |
There was a problem hiding this comment.
When a browser disappears with an unacknowledged response, _send_queue or _http_inflight_seq remains nonzero, so this condition prevents the HTTP session from ever expiring. serviceTcp() accepts a client only when _session == Session::NONE, meaning every subsequent raw TCP/5000 connection is rejected indefinitely even after the 10-second timeout; the user must reopen the WebUI to drain the response or reboot the device. A timed-out HTTP session should be discardable when a TCP client attempts to take over.
Useful? React with 👍 / 👎.
1 participant
What changed
Exact validation
Candidate:
2fd6c8bfd1b6a2cf05a3f991eddfa8e188ae87bd31296181181— success31296181177— success26378715a14eccafbde5ebfb5bca42d33e7384c0f6ef605f738658223ed4b7e8B957A8C50C054C8C1AFE39C009362D06CE873EDD5223BF5975712E668DE9E2FBD1EA3C3BE6106AC2BE7B86B3435055D72C1D71A5F9A5245C962F783AB16DC9BA192.168.0.39, authenticated WebUI load, valid TCP/5000DEVICE_INFO, and direct Public LoRa receiptRCC6-WEB-86C23289at SNR 12.0 dBRCC6-BLE-2FD6C8BFat SNR 11.75 dBBLE and Web/AP are intentionally separate firmware modes. Raw TCP/5000 is the full unauthenticated companion/admin protocol and is documented for trusted private LANs only.