Add Ultimate native-USB companion build - #15
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bf72d9779
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| extends = heltec_rcc6_ultimate_companion | ||
| build_flags = | ||
| ${heltec_rcc6_ultimate_companion.build_flags} | ||
| -D ENABLE_USB_INTERFACE |
There was a problem hiding this comment.
When this environment is flashed, it defines neither RCC6_WEB_AP nor BLE_PIN_CODE, so UltimateUIScreen takes its non-Web branch: the header reports BLE, the boot sequence reports BLE ADVERTISING, and the TRANSPORT action calls only isBluetoothEnabled()/enableBluetooth()/disableBluetooth(). Because the interface manager contains only an InterfaceType::USB interface, that action is a no-op and cannot disable or re-enable the actual companion transport. Add an explicit ENABLE_USB_INTERFACE UI path that labels USB and operates the serial interface.
Useful? React with 👍 / 👎.
1 participant
Adds a third mutually exclusive Ultimate transport: native USB. The build keeps the indexed framebuffer and full Ultimate UI while exposing the standard MeshCore binary companion protocol.