Make Web location advert sharing explicit - #2
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 103ac29374
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sensors.node_lat = latitude; | ||
| sensors.node_lon = longitude; | ||
| if (has_advertise) { | ||
| the_mesh.getNodePrefs()->advert_loc_policy = advertise ? ADVERT_LOC_PREFS : ADVERT_LOC_NONE; |
There was a problem hiding this comment.
When building the inspected heltec_rcc6_ultimate_companion_web environment, this reference is undefined: the companion implementation’s NodePrefs.h declares only ADVERT_LOC_NONE and ADVERT_LOC_SHARE, while ADVERT_LOC_PREFS belongs to the separate CommonCLI preference model and is not included here. Consequently the Ultimate Web firmware cannot compile; use the companion’s ADVERT_LOC_SHARE value (or deliberately add the missing policy to its preference model). The workflow currently builds only the Ultimate BLE environment, where this file is preprocessor-excluded, so its compiler job does not expose the failure.
Useful? React with 👍 / 👎.
1 participant
Adds an explicit sharing choice and confirmation to browser location transfer, persists the MeshCore advert policy, preserves compatibility for older API clients, and regenerates the verified embedded WebUI.