introduce typescript - #447
Conversation
n-rook
left a comment
n-rook
left a comment
There was a problem hiding this comment.
Nice; using ts will be really convenient and make it easier to maintain the frontend without getting lost in the complexity of it.
| <script> | ||
| const showGameColumn = "{{show_game}}"; | ||
| const showRouteColumn = "{{show_route}}"; | ||
| const aaaa = "aaaaa"; |
| @@ -1,205 +1,200 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
Sorry to be annoying by saying this, but: We really shouldn't check in generated code. Rather, we should recreate it whenever we deploy.
If you really need to, it might be okay to check it in as an intermediate step while you're trying to get the ts deploy working, but if so, please put a giant comment at the top warning that this is generated code. But it'd be way better to do it in one go.
| } | ||
|
|
||
| function ensureTickboxSync(): void { | ||
| activeFilters = initializeFilters(); |
There was a problem hiding this comment.
Er--- why are we calling initializeFilters() three times in this module?
|
|
||
| json_dict = {} | ||
| json_dict["Id"] = replay.id | ||
| json_dict["id"] = replay.id |
There was a problem hiding this comment.
IMO you should really make these changes in a separate PR; they make this one look much bigger than it needs to be
2 participants
Adding types here to make the logic easier to follow