Improved rounded corners for correspondence - #2142
Open
lucascumsille wants to merge 1 commit into
Open
Conversation
- Now that the white background is applied to the correspondence text and event actions, there is no need for the pseudo elements that were creating the rounded corners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes part of: mysociety/alaveteli#9294
What does this do?
Why was this needed?
I noticed that the problem was not only happening on the
correspondence--currentthat class only made it more obvious because of the box-shadow. I changed the background colour of the body to something darker and you can see the sharp corners for everycorrespondenceelementImplementation notes
Screenshots
correspondence--currentNotes to reviewer