WIP: Add admin search for info requests - #9439
Draft
laurentS wants to merge 4 commits into
Draft
Conversation
garethrees
reviewed
Aug 7, 2026
Collaborator
Author
|
Added another commit to do a much faster The method is generic enough to also take care of |
laurentS
force-pushed
the
admin-search-info-requests
branch
from
August 7, 2026 16:05
e3dcdb1 to
a7dec83
Compare
laurentS
force-pushed
the
admin-search-info-requests
branch
2 times, most recently
from
August 7, 2026 16:25
0ab3be3 to
813002e
Compare
laurentS
force-pushed
the
admin-search-info-requests
branch
from
August 7, 2026 16:51
813002e to
3b9a7af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
#8814
What does this do?
This PR marks
InfoRequestas searchable with the new search engine.Why was this needed?
Implementation notes
This is mostly adapted from the previous PR for
PublicBody.I took the opportunity to optimise the view a bit as well. For a full page of requests, the rendering time is divided by 2-4 locally, and number of requests to db drop from ~416 to ~20.
This is probably one of the models where initial indexing time is going to matter a bit, at least for WDTK. If it runs at roughly the same speed as my local test, you're looking at ~6.5h of indexing time. I will try to implement a more generic version of the
reindex_allI wrote in https://github.com/mysociety/alaveteli/pull/9415/changes, which can be used by the various models that don't need any ruby attributes in theirSearchDocuments.Screenshots
Notes to reviewer
Have you updated the changelog? If this is not necessary, put square brackets around this: [skip changelog]