Add searchable to Citation - #9418
Open
gbp wants to merge 3 commits into
Open
Conversation
Declare Citation searchable on its source_url, allowing instances to be searched through the new SearchDocument and the new interface.
The admin citation listing searched source URLs with a bespoke SQL LIKE class method. Move it onto the shared search interface instead by having the admin controller call search_scope, forcing the PostgreSQL backend with exact mode so partial URL fragments still match. Drop the now-unused Citation.search. The model spec for it goes with it; the admin controller spec indexes its records and exercises the new path.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Alterative to #9412
What does this do?
Add searchable to Citation
Declare Citation searchable on its source_url, allowing instances to be
searched through the new SearchDocument and the new interface.