Pro page improvements - #9417
Open
lucascumsille wants to merge 5 commits into
Open
Conversation
They were causing an odd misalignment with sibling elements.
- This adds a gap on mobile between the elements. - Prevents long lines of text on medium screens.
lucascumsille
force-pushed
the
quotes-pro-page
branch
from
July 29, 2026 07:07
5479e53 to
8eae312
Compare
garethrees
approved these changes
Aug 7, 2026
garethrees
left a comment
garethrees
left a comment
Member
There was a problem hiding this comment.
Looks great. Worth adding a changelog note, but no need to get specific about the template as these get automatically detected when we create a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes: mysociety/whatdotheyknow-theme#2132
What does this do?
margin-bottomofmarketing-sectionso on mobile is3eminstead of5emalaveteli-quote. I left some notes for the CSS variables.marketing__roles__columnsdidn't have a gap between elements on mobile. and I took the opportunity to change it to flex to use itsgapproperty.marketing_quotepartialWhy was this needed?
It started just as a PR to add a quote to the page. But during the testing I noticed some things to improve:
The "Research" item had some extra space.
Also the spacing between sections on mobile seem a bit much.
Implementation notes
Screenshots
marketing__roles__columnsScreen.Recording.2026-07-29.at.06.56.22.mov
Notes to reviewer
Should I update the changelog as well advising the addition of
marketing_quotepartial?Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog