Conversation
Replace .bind() with .on(), .unbind() with .off(), and $.error() with throw new Error() to prepare for jQuery 3 upgrade. These APIs were removed in jQuery 3.0.
Replace $.isFunction() with typeof === 'function' in jquery.flot and jquery.flot.errorbars. Replace $.isArray() with Array.isArray() in selectize. Replace $.error() with throw new Error() in dropit. These jQuery utility methods were removed in jQuery 3.0.
The sprockets manifests required 'jquery' which resolved to jQuery 1.12.4. That version uses setAttribute(eventName, "t") for feature detection, which triggers CSP script-src-attr violations. jQuery 3.4+ removed this feature detection. Switch to 'jquery3' which resolves to jQuery 3.7.1 shipped by jquery-rails 4.6.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Upgrade to jQuery v3
Why was this needed?
The sprockets manifests required 'jquery' which resolved to jQuery 1.12.4. That version uses setAttribute(eventName, "t") for feature detection, which triggers CSP script-src-attr violations.
jQuery 3.4+ removed this feature detection. Switch to 'jquery3' which resolves to jQuery 3.7.1 shipped by jquery-rails 4.6.1.