Move setSelect into the Jcrop init callback on the photo crop page - #9259
Open
c-tonneslan wants to merge 1 commit into
Open
Move setSelect into the Jcrop init callback on the photo crop page#9259c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
Jcrop returns the instance via a callback, so jcrop_api is undefined when the next statement runs. The browser throws 'Cannot read properties of undefined (reading setSelect)' and the default crop box never appears, which is what @FOIMonkey reported in mysociety#9196. Moving the setSelect call inside the init callback fires it once the api object actually exists. Closes mysociety#9196 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9196.
jcrop_apionly gets assigned inside the Jcrop init callback (function(){ jcrop_api = this; ... }), butsetSelectwas being called the next line down, before the callback had run. Browsers were throwingCannot read properties of undefined (reading 'setSelect')and the default crop selection wasn't drawn, so users had to know to drag and select before they could save (this is exactly what @FOIMonkey hit).Move the
setSelectcall inside the callback so it runs after the api object exists.