ci: add F5 signer key "arut" to nginx PGP verification list#77
Merged
Conversation
tools/ci-build.sh imports nginx release-signing keys before verifying the source tarball's detached signature. Current nginx releases (1.31.2 tested) are signed by Roman Arutyunyan <r.arutyunyan@f5.com>, RSA key 43387825DDB1BB97EC36BA5D007C8D7C15D87369 — the F5-era signer — whose public key is served at https://nginx.org/keys/arut.key. It was missing from the import loop, so `gpg --verify` found no matching key, verification failed, and ci-build.sh exited before any build. Add "arut" to the loop. Verified: importing arut.key and checking nginx-1.31.2.tar.gz.asc yields "Good signature". The loop tolerates missing keys (|| true), so this is safe as signers rotate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MINOR (infra) found during audit-fix validation.
Problem
tools/ci-build.shimports nginx release-signing keys before verifying the source tarball’s detached PGP signature. Current nginx releases (1.31.2 tested) are signed by Roman Arutyunyan<r.arutyunyan@f5.com>, RSA key43387825DDB1BB97EC36BA5D007C8D7C15D87369(the F5-era signer). That key was missing from the import loop, sogpg --verifyhad no matching key → verification failed →ci-build.shexited before any build.Fix
Add
arut(served athttps://nginx.org/keys/arut.key) to the loop.Verified locally: importing
arut.keyand checkingnginx-1.31.2.tar.gz.asc→The loop tolerates missing keys (
|| true), so this stays safe as signers rotate.