Skip to content

console.error replace throw Error #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liushooter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

console.error replace throw Error #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/simditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*!
* Simditor v2.3.6
* http://simditor.tower.im/
* 2015-12-21
* 2016-09-03
*/
(function (root, factory) {
if (typeof define === 'function' && define.amd) {
Expand Down Expand Up @@ -1979,7 +1979,7 @@ Toolbar = (function(superClass) {
continue;
}
if (!this.constructor.buttons[name]) {
throw new Error("simditor: invalid toolbar button " + name);
console.error("simditor: invalid toolbar button " + name);
continue;
}
this.buttons.push(new this.constructor.buttons[name]({
Expand Down
6 changes: 3 additions & 3 deletions site/assets/scripts/simditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1974,7 +1974,7 @@ Toolbar = (function(superClass) {
continue;
}
if (!this.constructor.buttons[name]) {
throw new Error("simditor: invalid toolbar button " + name);
console.error("simditor: invalid toolbar button " + name);
continue;
}
this.buttons.push(new this.constructor.buttons[name]({
Expand Down Expand Up @@ -2679,8 +2679,8 @@ Simditor.i18n = {
'linkText': '链接文字',
'linkUrl': '链接地址',
'linkTarget': '打开方式',
'openLinkInCurrentWindow': '在新窗口中打开',
'openLinkInNewWindow': '在当前窗口中打开',
'openLinkInCurrentWindow': '在当前窗口中打开',
'openLinkInNewWindow': '在新窗口中打开',
'removeLink': '移除链接',
'ol': '有序列表',
'ul': '无序列表',
Expand Down
2 changes: 1 addition & 1 deletion src/toolbar.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class Toolbar extends SimpleModule
continue

unless @constructor.buttons[name]
throw new Error "simditor: invalid toolbar button #{name}"
console.error "simditor: invalid toolbar button #{name}"
continue

@buttons.push new @constructor.buttons[name]
Expand Down
2 changes: 1 addition & 1 deletion styles/simditor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*!
* Simditor v2.3.6
* http://simditor.tower.im/
* 2015-12-21
* 2016-09-03
*/
@font-face {
font-family: 'Simditor';
Expand Down