Prevent NPE on onHostResume - #9
Open
firefueled wants to merge 2 commits into
Open
Conversation
This call to helper.onResume() was causing intermitent NPE's They happened during app initialization but I could not identify the reason; usually after a reload
Member
|
If |
jhen0409
requested changes
Jun 19, 2017
| helper.onPause(); | ||
| // Don't know why this would be null at this point | ||
| if (helper != null) { | ||
| helper.onResume(); |
Member
There was a problem hiding this comment.
onPause, and shouldn't need to handle this event?
Author
There was a problem hiding this comment.
I agree that onPause shouldn't need that verification. I added it just as a precaution. I've never had an NPE pointing to onPause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This call to helper.onResume() was causing intermittent NPE's
They happened during app initialization but I could not identify the reason; usually after a reload
Adding a null check on onHostPause as well, just in case