fix(security): remove auto-update RCE in legacy/beta Python agent (#9671) - #5
Open
TheDude4224 wants to merge 1 commit into
Open
fix(security): remove auto-update RCE in legacy/beta Python agent (#9671)#5TheDude4224 wants to merge 1 commit into
TheDude4224 wants to merge 1 commit into
Conversation
…9671)
check_for_update() polled GET /api/v1/agents/version for a coordinator-supplied
{version,url}, downloaded that URL over the network with no signature check and
no cert/host pinning (only a substring "sanity check" for def register/def
poll_loop), overwrote the running file and os.execv'd the interpreter. A MITM on
the download or a compromised/rogue coordinator = arbitrary code execution on
every provider box.
Fix: remove the fetch-and-exec path entirely. check_for_update()/auto_update_loop()
are now inert no-ops; the startup call and the hourly auto_update thread are
removed from __main__. Core agent behaviour (register, heartbeat, ws_loop,
poll_loop) is unchanged. Aligns with the canonical myai-agent PyPI package, which
has no self-update; updates ship out-of-band via installer / pip.
Board: #9671 (Launch P0). py_compile passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board #9671 (Launch P0). Removes the fetch-and-exec auto-update path.