Add Podcast Owner Custom Definitions#192
Merged
Merged
Conversation
Some users were saying their podcasts were getting rejected since `podcast.IOwner` wasn't being set. This PR adds that functionality to issue mxpv#171. * Did not disturb existing custom Author string, as users may already be using that (wasn't sure on the backwards compatibility with this repo). * "Name" needed a prefix, since there was already Title and Description. Picked `Owner` for now. * Added to existing Unit Test to ensure it gets set when custom config is used. NOTE: I do not have a way to test this as I do not use this repo. This is just a drive-by PR to help the authors.
eduncan911
changed the title
eduncan911
commented
Oct 28, 2020
| quality = "low" | ||
| filters = { title = "regex for title here" } | ||
| clean = { keep_last = 10 } | ||
| custom = { cover_art = "http://img", cover_art_quality = "high", category = "TV", subcategories = ["1", "2"], explicit = true, lang = "en" } |
Contributor
Author
There was a problem hiding this comment.
i figured you'd want this cleaned up and formatted a bit. :)
Owner
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users were saying their podcasts were getting rejected since
podcast.IOwnerwasn't being set. This PR adds that functionality to issue #171.Ownerfor now.NOTE: I do not have a way to test this as I do not use this repo. This is just a drive-by PR to help the authors.