✨ Complete: always_on_top configuration and controls - #32
Conversation
Implement complete always_on_top support across PetWindow, SettingsDialog, and TrayMenu. Initialize window flags correctly, support dynamic flag updates, and provide unified synchronization. Added tests to verify flag modifications.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change completes the missing/half-baked always_on_top configuration feature in Desktop Pet Cat.
By integrating always_on_top fully into ConfigManager, PetWindow, SettingsDialog, and TrayMenu, we have provided a seamless and highly interactive user experience.
🎯 What was added:
PetWindow's initialization, respect the config'salways_on_topsetting (default: True).set_always_on_toptoggling that handles PySide6's window flags and re-shows the window.SettingsDialogto view/edit settings.TrayMenufor quick toggle with synchronization across the system.📋 Checklist:
🧪 Testing:
Run all tests using:
PYTHONPATH=. python3 -m unittest discover testsPR created automatically by Jules for task 14400016884025613417 started by @mx57