Skip to content

πŸ› Fix: StatsDialog layout and points accuracy - #26

Open
mx57 wants to merge 1 commit into
feat/desktop-pet-cat-implementation-13128440384193574434from
fix/stats-dialog-layout-17237459592785599776
Open

πŸ› Fix: StatsDialog layout and points accuracy#26
mx57 wants to merge 1 commit into
feat/desktop-pet-cat-implementation-13128440384193574434from
fix/stats-dialog-layout-17237459592785599776

Conversation

@mx57

@mx57 mx57 commented Jul 18, 2026

Copy link
Copy Markdown
Owner

This pull request resolves a critical UI layout bug and a data synchronization/accuracy issue inside the desktop cat pet's StatsDialog.

🐞 Problem:

  1. The total affection points label ("ВсСго: {points} ❀️") was missing entirely from the StatsDialog UI because it was created but never added to any layout. The horizontal layout layout stats_row was also orphaned.
  2. The displayed stats did not account for the pending, buffered points/KPS that are active in memory but not yet flushed to the database, leading to a delay/desynchronization in user stats when opening the dialog.

βœ… Solution:

  1. Correctly structured the horizontal layout in the StatsDialog's progress tab: added both points_label and kps_label to stats_row and integrated stats_row into the parent vertical layout.
  2. Improved data accuracy by fetching the live, in-memory pending points and current max KPS from the parent window's InputManager if initialized.
  3. Updated the .jules/bolt.md journal with insights on layout completeness and data accuracy.

πŸ§ͺ Testing:

  • Ran the visual verification script to successfully regenerate and register screenshots.
  • Verified all unit tests successfully passed with pytest.

PR created automatically by Jules for task 17237459592785599776 started by @mx57

- Properly add points_label and kps_label to stats_row (QHBoxLayout).
- Add stats_row layout to the main layout (QVBoxLayout).
- Retrieve active, pending in-memory points and max KPS from parent window's InputManager if available, ensuring data accuracy in real-time.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant