Skip to content

Fix unitialized local variable in RGFilterManagerWindow::getPatternFilter #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amaa-99 wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −26
Open

Fix unitialized local variable in RGFilterManagerWindow::getPatternFilter #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 15 additions & 26 deletions gtk/rgfiltermanager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,53 +718,42 @@ void RGFilterManagerWindow::getStatusFilter(RStatusPackageFilter & f)

void RGFilterManagerWindow::getPatternFilter(RPatternPackageFilter &f)
{
GtkTreeIter iter;
bool exclude;
string pattern;
RPatternPackageFilter::DepType type;
gchar *dopatt, *what, *text;
Comment thread
amaa-99 marked this conversation as resolved.

//cout << "RGFilterEditor::getPatternFilter()"<<endl;
f.reset();

bool valid =
gtk_tree_model_get_iter_first(GTK_TREE_MODEL(_patternListStore),
&iter);
// Walk through the list, reading each row.
GtkTreeIter iter;
bool valid = gtk_tree_model_get_iter_first(GTK_TREE_MODEL(_patternListStore), &iter);
while (valid) {
/* Walk through the list, reading each row */
gchar *dopatt;
gchar *what;
gchar *text;
gtk_tree_model_get(GTK_TREE_MODEL(_patternListStore),
&iter,
PATTERN_DO_COLUMN, &dopatt,
PATTERN_WHAT_COLUMN, &what,
PATTERN_TEXT_COLUMN, &text, -1);

// first look at the "act" code
if (strcmp(dopatt, ActOptions[0]) == 0)
exclude = false;
else
exclude = true;
bool exclude = (strcmp(dopatt, ActOptions[0]) != 0);

// then check the options
for (int j = 0; DepOptions[j]; j++) {
for (size_t j = 0; DepOptions[j] != NULL; j++) {
if (strcmp(what, _(DepOptions[j])) == 0) {
type = (RPatternPackageFilter::DepType) j;
// then do the pattern (we convert the text to locale to support translated descriptions)
RPatternPackageFilter::DepType type = (RPatternPackageFilter::DepType) j;
f.addPattern(type, utf8_to_locale(text), exclude);
break;
}
}
// then do the pattern (we convert the text to locale to support
// translated descriptions)
f.addPattern(type, utf8_to_locale(text), exclude);

valid = gtk_tree_model_iter_next(GTK_TREE_MODEL(_patternListStore),
&iter);
valid = gtk_tree_model_iter_next(GTK_TREE_MODEL(_patternListStore), &iter);

g_free(dopatt);
g_free(what);
g_free(text);
}

f.setAndMode(gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON
(gtk_builder_get_object(_builder,
"radiobutton_properties_and"))));

f.setAndMode(gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(gtk_builder_get_object(_builder, "radiobutton_properties_and"))));
}

void RGFilterManagerWindow::editFilter()
Expand Down