Skip to content

Fix the "enumeration values 'ButtonsDefault' and 'ButtonsOk' not handled in switch"#225

Merged
mvo5 merged 1 commit into
mvo5:masterfrom
amaa-99:105-fix-the-enumeration-values-buttonsdefault-and-buttonsok-not-handled-in-switch
Jul 9, 2026
Merged

Fix the "enumeration values 'ButtonsDefault' and 'ButtonsOk' not handled in switch"#225
mvo5 merged 1 commit into
mvo5:masterfrom
amaa-99:105-fix-the-enumeration-values-buttonsdefault-and-buttonsok-not-handled-in-switch

Conversation

@amaa-99

@amaa-99 amaa-99 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Added the explicit default to the switch statement.
(closes amaa-99#106)

@mvo5 mvo5 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is nice. While work on this, maybe worth renaming "common/ruserdialog.h" defres->defaultReponse there too. Two small inline suggesitons.

Comment thread gtk/rguserdialog.h Outdated
Comment thread gtk/rguserdialog.cc
…led in switch":

Added the explicit default to the switch statement.
@amaa-99 amaa-99 force-pushed the 105-fix-the-enumeration-values-buttonsdefault-and-buttonsok-not-handled-in-switch branch from d765792 to 1f0e1df Compare July 9, 2026 18:45

@mvo5 mvo5 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mvo5 mvo5 merged commit dca96d1 into mvo5:master Jul 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge: Fix the "enumeration values 'ButtonsDefault' and 'ButtonsOk' not handled in switch"

2 participants