Skip to content

Mixed HTTP and HTTPS cases #9

Open

Description

@ynunokawa

Test for @tsamaya 's PR #8 to allows https.

If only warning, we can marge it and will fix other issues by next patch.

Activity

  1. changed the title [-]Mixed HTTPS and HTTPS cases[/-] [+]Mixed HTTP and HTTPS cases[/+] on Dec 6, 2015
  2. ynunokawa commented on Dec 6, 2015

    @ynunokawa
    MemberAuthor

    Basemap tiles of CartoDB and OSM is accessed via http.
    However they show warning messages.

    Current

    L.tileLayer('http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', {

    Better solution

    L.tileLayer('//{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', {

    Anything else? :octocat:

  3. tsamaya commented on Dec 6, 2015

    @tsamaya
    Contributor

    there is also

    I can update my branch linked to the PR so it will automatically added to the PR

  4. ynunokawa commented on Dec 6, 2015

    @ynunokawa
    MemberAuthor

    Your work is fast and amazing! 👍

    You can update them?
    Thanks a lot!

  5. tsamaya commented on Dec 6, 2015

    @tsamaya
    Contributor

    I work on it. I will update it

  6. tsamaya commented on Dec 6, 2015

    @tsamaya
    Contributor

    done except about geojson loaded from Open Data Portal of Esri Japan. the SSL certificat gives me a warning.

  7. tsamaya commented on Dec 6, 2015

    @tsamaya
    Contributor

    certificat from cartocdn.com also gives me a warning. ssl is not valid (certicat belongs to a.ssl.fastly.net)

    we can change to tiles to another provider (stamen has a black and white map; esri dark background ; other one ?)

    the geojson can be embedded into the repo.

  8. ynunokawa commented on Dec 7, 2015

    @ynunokawa
    MemberAuthor

    It is BETTER that the samples of the repo is supported HTTPS.
    And It is OK not to change the cases that show a warning message at this time.
    It is an example. I think that it should not change UI rashly.
    If adding the geojson into the repo and updating the links, I try to marge the PR.

    After marge it, we will continue to face this issue (the links in README use http).

  9. tsamaya commented on Dec 7, 2015

    @tsamaya
    Contributor

    Hi @ynunokawa,

    It is nice to work on it, thank you for this repo !

  10. ynunokawa commented on Dec 7, 2015

    @ynunokawa
    MemberAuthor

    Awesome! 👍

    Stamen is better for everyone to use our examples because it is under CC BY 3.0.
    If using Esri Basemap, we want to propose some ideas to use the feature of Esri Leaflet.

  11. tsamaya commented on Dec 9, 2015

    @tsamaya
    Contributor

    Hi, I found cartoDB tiles working on both schemes : http and https.

    http://tsamaya.github.io/map-effects-100/Leaflet/
    https://tsamaya.github.io/map-effects-100/Leaflet/
    🚀

    So I added a commit on my PR #8

  12. ynunokawa commented on Dec 10, 2015

    @ynunokawa
    MemberAuthor

    I have confirmed them, excellent!
    Could you also commit to embed the GeoJSON from Open Data Portal into the repo?

  13. tsamaya commented on Dec 10, 2015

    @tsamaya
    Contributor

    I named the file coming fomr OpenDataPortal Shizuoka_100_waterside.geojson as I don't really understand the name coming from the portal : 静岡県_静岡のみずべ100選.geojson

    Commit done right now 🎆

  14. ynunokawa commented on Dec 10, 2015

    @ynunokawa
    MemberAuthor

    Good! there is no problem.
    I have marged your PR!! :octocat:

    Thanks a lot 😄 😄 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions