ed/sdk-ng build, merging back to test branch#30
Open
eropple wants to merge 4 commits into
Open
Conversation
eropple
force-pushed
the
ed/sdk-ng-build
branch
from
86b9365 to
1e3bc2b
Compare
eropple
force-pushed
the
ed/sdk-ng-build
branch
from
1e3bc2b to
661d83c
Compare
james-mux
approved these changes
Apr 6, 2021
james-mux
left a comment
james-mux
left a comment
There was a problem hiding this comment.
To me this looks good! I can pull it down and try it out if you'd like to be certain, but style-wise I haven't seen anything which looks like a major no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.