fix(rm-costs): fix period filter not working after page reload with URL params#68
Merged
ilramdhan merged 2 commits intoJul 22, 2026
Conversation
…RL params - Fix stale closure in auto-select effect reading filters.period from a potentially outdated closure instead of the latest value. Added filtersPeriodRef to always read the most up-to-date period value, preventing the auto-select from overriding URL-provided period. - Fix useUrlState stateRef sync from useEffect to synchronous render-time assignment, ensuring setState updater always reads the latest state even when called from other effects in the same render cycle.
React Compiler's react-hooks/refs rule flags mutating stateRef.current during render; move the assignment into a useEffect so it runs after commit instead, fixing the frontend lint CI failure.
github-project-automation
Bot
moved this from Todo
to Done
in Goapps Roadmap [Frontend]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stale closure in auto-select effect reading filters.period from a potentially outdated closure instead of the latest value. Added filtersPeriodRef to always read the most up-to-date period value, preventing the auto-select from overriding URL-provided period.
Fix useUrlState stateRef sync from useEffect to synchronous render-time assignment, ensuring setState updater always reads the latest state even when called from other effects in the same render cycle.